Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo-ci-improvement] : update GHA to run e2e tests #248

Merged
merged 6 commits into from
Nov 27, 2024
Merged

[repo-ci-improvement] : update GHA to run e2e tests #248

merged 6 commits into from
Nov 27, 2024

Conversation

rahulait
Copy link
Collaborator

@rahulait rahulait commented Nov 26, 2024 •
edited
Loading

Fixes #145

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

This PR enables running ccm e2e tests against a CAPL deployed cluster.

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.63%. Comparing base (3510bc4) to head (a6abda7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   56.63%   56.63%           
=======================================
  Files          12       12           
  Lines        2412     2412           
=======================================
  Hits         1366     1366           
  Misses        892      892           
  Partials      154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulait rahulait force-pushed the gha-e2e-tests branch 2 times, most recently from 9916317 to 62ef965 Compare November 26, 2024 17:39
@rahulait rahulait force-pushed the gha-e2e-tests branch 3 times, most recently from 0d9feeb to e1ace86 Compare November 26, 2024 22:57
@rahulait rahulait changed the title update GHA to run e2e tests [repo-ci-improvement] : update GHA to run e2e tests Nov 27, 2024
AshleyDumaine
AshleyDumaine reviewed Nov 27, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@AshleyDumaine
Copy link
Member

I think this also might close #165 ?

@rahulait rahulait merged commit b4ee2af into main Nov 27, 2024
4 checks passed
This was referenced Nov 27, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshleyDumaine AshleyDumaine AshleyDumaine approved these changes

Assignees
No one assigned
Labels
repo-ci-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get e2e Tests Working Again
2 participants
@rahulait @AshleyDumaine